Skip to content

Comments

register zstd buffers if enabled#6422

Merged
onursatici merged 2 commits intodevelopfrom
os/register-zstd
Feb 11, 2026
Merged

register zstd buffers if enabled#6422
onursatici merged 2 commits intodevelopfrom
os/register-zstd

Conversation

@onursatici
Copy link
Contributor

@onursatici onursatici commented Feb 11, 2026

Does this PR closes an open issue or discussion?

  • Closes #.

What changes are included in this PR?

if unstable encodings and zstd features are enabled, add zstd buffers to the session

What is the rationale for this change?

How is this change tested?

Are there any user-facing changes?

@onursatici
register zstd buffers if enabled
0f28f5c 
Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici enabled auto-merge (squash) February 11, 2026 14:06
@onursatici onursatici added the changelog/fix A bug fix label Feb 11, 2026
@onursatici
test
72759d3 
Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici merged commit 9fab265 into develop Feb 11, 2026
45 of 46 checks passed
@onursatici onursatici deleted the os/register-zstd branch February 11, 2026 14:51
@connortsui20
Copy link
Contributor

connortsui20 commented Feb 16, 2026 •
edited
Loading

When I run cargo nextest on develop I get a failure as such:

        FAIL [   0.124s] vortex-test-e2e tests::test_compression_determinism
  stdout ───

    running 1 test
    test tests::test_compression_determinism ... FAILED

    failures:

    failures:
        tests::test_compression_determinism

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s

  stderr ───

    thread 'tests::test_compression_determinism' panicked at vortex-test/e2e/src/lib.rs:49:13:
    assertion `left == right` failed: Run 0 produced size 216188
      left: 216188
     right: 216156
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 12 tests still running

This is likely something weird with features?

(MacOS)

@onursatici
Copy link
Contributor Author

onursatici commented Feb 16, 2026

#6537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

Assignees

No one assigned

Labels

changelog/fix A bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onursatici @connortsui20 @robert3005